micahmoore/pserv
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fixed out-of-bound error caused by wrong use of vsnprintf

Browse Source
This commit is contained in:
Godmar Back 2018-05-01 15:53:30 -04:00
parent 960fec20f8
commit f0ea5f0f74
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/http.c
View File

@ -124,7 +124,8 @@ http_add_header(buffer_t * resp, char* key, char* fmt, ...)
va_start(ap, fmt);
char *error = buffer_ensure_capacity(resp, MAX_HEADER_LEN);
resp->len += vsnprintf(error, MAX_HEADER_LEN, fmt, ap);
int len = vsnprintf(error, MAX_HEADER_LEN, fmt, ap);
resp->len += len > MAX_HEADER_LEN ? MAX_HEADER_LEN - 1 : len;
va_end(ap);
buffer_appends(resp, "\r\n");
@ -222,7 +223,8 @@ send_error(struct http_transaction * ta, enum http_response_status status, const
va_start(ap, fmt);
char *error = buffer_ensure_capacity(&ta->resp_body, MAX_ERROR_LEN);
ta->resp_body.len += vsnprintf(error, MAX_ERROR_LEN, fmt, ap);
int len = vsnprintf(error, MAX_ERROR_LEN, fmt, ap);
ta->resp_body.len += len > MAX_ERROR_LEN ? MAX_ERROR_LEN - 1 : len;
va_end(ap);
ta->resp_status = status;
return send_response(ta);